Daniel Morrison - All Comments

Comment on 'Git Submodules, Part 2' by hgh

2008-05-09T06:13:35Z

I LOVE GIT! Thanks for the awesome code!

Eddie HGH

Comment on 'Git Submodules, Part 2' by John-Paul Bader

2008-04-19T10:11:37Z

Sorry, wrong line number – its 526 in my verion – in the git hub version its 534

self.class.base_class.update_all(”#{left_column_name} = (#{left_column_name} – #{diff})”,”#{left_column_name} >= #{right}”)

Comment on 'Git Submodules, Part 2' by John-Paul Bader

2008-04-19T10:08:14Z

Hey there – this comment is off topic and concerning your awesome nested set plugin which i have problems with. I’m using postgresql and it seems that “prune_from_tree” doesn’t work in postgres where the line 526 in awesome_nested_set.rb would generate this query:

UPDATE pages SET lft = (lft – 2) WHERE (lft >= 36) ORDER BY lft

which is incorrect syntax in Postgres. I was also wondering if the order statement is really neccessary at this particular part of the module. I couldn’t figure out where it comes from anyway because its not in line 526. Maybe you have the motivation to fix this for postgresql. Feel free to contact me via mail so I can give you more feedback in case you don’t ever use postgres.

Kind regards, John

Comment on 'Rails Plugin: imap_authenticatable' by Josh Merchant

2008-04-18T04:22:44Z

Awesome idea. Great for pitching enterprise rails apps.

Added it to my project… however experienced some problems.

I don’t know how your particular IMAP server responded to your request, however using a standard email one caused some issues. Even though the login credentials were right, it still seemed to return false.

Wasn’t a big deal to fix.. just thought you might be interested in the solution:

login = imap.authenticate(‘LOGIN’, username, password) if login[:name] == ‘OK’ if imap_authenicatable_options[:allow_new_users] find_or_create_by_login(username) else find_by_login(username) end else false end rescue false ensure imap.disconnect

Works like a charm :-)

Comment on 'Git Submodules, Part 2' by Ryan McGeary

2008-04-13T00:03:44Z

Daniel, Thanks for taking the time on this detailed response. Good info, especially on how submodules handle the commit revision. I now have a better understanding of things which will help me make a more informed decision on my git repositories, especially since piston 2.0 isn’t ready yet, and braid currently has self-proclaimed warnings of being riddled with issues.

Comment on 'Git Submodules' by Daniel Morrison

2008-04-12T18:04:14Z

Good comments, Ryan. I posted a follow-up.

Comment on 'Git Submodules' by Ryan McGeary

2008-04-12T13:58:45Z

Daniel, Good post, but isn’t there a small advantage to a piston or braid-like approach where all the files are in your own repository? What happens during deployments? Doesn’t the deployment now rely on a possible many remote repositories to succeed? Consider both vendor/rails and a possible many vendor/plugins each with their own submodule.

I think I also missed an important point. How does Matt’s git submodule update avoid pulling a later version of edge rails than the original revision that you intended? The .gitmodules file only seems to specify the public clone url without any commit revision.

Comment on 'Git Submodules' by Daniel Morrison

2008-04-10T03:58:17Z

Mark,

Good point. Maybe I’m too hard on svn, by only pointing to the common (non-version-specified) use case.

Comment on 'Git Submodules' by Mark Van Holstyn

2008-04-09T03:54:34Z

Thanks for the info on submodules Dan. Just a slight correction in regards to SVN externals though. Externals do allow you to specify which revision you want to be tied to, for example:

rails -r9243 http://svn.rubyonrails.org/rails/trunk

Comment on 'CSS Naked Day 2008' by adi

2008-04-05T20:34:03Z

Cool.. I will get 2 or even 3 of my sites nude…

Why we do not create Image Naked day also :) ?

Thanks

Comment on 'MicroReviews' by Sam Straw

2008-04-03T05:27:55Z

I always wondering why people use domains with WS as tld :), this is the first time i found this TLD useful :)

Good luck! Sam Straw

Comment on 'The Road to Randomness' by Dan Parker

2008-03-22T01:23:45Z

I know SQL does a lot of math quite happily too – there should be a way to create a query that has a mathematical algorithm centered around random() that can do it quite efficiently. Thinking out loud here as I research…

For starters, you can use “FLOOR180))” to get a random integer between 20 and 200. If you can assume that most numbers exist in your id’s, you could grab a random match: “id IN (FLOORhighest_id_in_table)))”.

Now, you’d need to gather that highest_id_in_table. The following is a start:

SELECT * FROM logs WHERE id IN (FLOOR(@highest := (SELECT MAX FROM logs)))), FLOOR@highest)));

- but I’m not sure if it’s executing the (SELECT MAX FROM logs) every time it compares a record, or not. With just a little more work (I have to go now, the evening activity is calling :P), you could get the @highest (a client variable in sql) to set only if it hasn’t been set yet. In any case, it gets carried over the rest of the equation. In fact, if you run that query, you’ll see very random results - on a table of over 3000 records, I got anywhere from 0 to 5 records returned. That was some good learning, anyway.

My real suggestion is to run two queries: 1) top = SELECT MAX as top FROM logs; #not a big overhead on an indexed integer column 2) Gather 6 random ruby bits: r = [rand(top),rand(top),...] 3) records = [“SELECT * FROM logs WHERE id IN (?) GROUP BY id LIMIT 3”, r]

Comment on 'A prettier truncate helper' by Daniel Morrison

2008-03-20T22:59:03Z

Joe:

Yes, that’s because the regexp is specifically looking for word characters (\w). I guess I could refactor it to look for spaces instead, but I don’t have that immediate need.

Comment on 'A prettier truncate helper' by Joe Van Dyk

2008-03-20T07:12:24Z

Hm, it seems to fail if the text is all symbols (and no letters).

Try that function with this text:

(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.(> ^.( O_o)>

Seems to fail for me on my site.

Comment on 'CSS Naked Day' by Eddie

2008-03-15T00:56:21Z

Awesome plugin.. I found it from Dustin page..

Thanks!